Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add analysis for route generation by controllers and UrlGeneratorInterface #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

@DaDeather
Copy link

@DaDeather DaDeather commented Jan 20, 2022
edited
Loading

Hi there.

we were in need of this feature to detect possible dead route generation when using dynamicly generated route "name"s through symfony by its namespace_controller_method style.

Therefore I've created this simple analysis which I would like to share with anyone in the same need.

@DaDeather DaDeather force-pushed the add-analysis-for-route-generation branch from b5d7311 to d35cd60 Compare January 20, 2022 20:28
@DaDeather DaDeather force-pushed the add-analysis-for-route-generation branch from d35cd60 to 2892226 Compare January 25, 2022 06:58
Copy link
Author

@ondrejmirtes would this feature be something you would see in this project?

Copy link
Member

I need @lookyman to look at this, I'm not able to evaluate it myself as I personally don't use Symfony. Thanks.

DaDeather reacted with thumbs up emoji lookyman reacted with eyes emoji

Copy link
Author

@lookyman did you had any chance to look over it or at least for letting me know if this might be a feature of relevance for this plugin?

Copy link
Collaborator

lookyman commented Feb 2, 2022

I did have a look. It's an OK feature, but to be honest, it's pretty specific use case, and I'm not sure I really want to maintain it here..

DaDeather reacted with thumbs up emoji

Copy link
Author

I did have a look. It's an OK feature, but to be honest, it's pretty specific use case, and I'm not sure I really want to maintain it here..

It is definitely a specific feature and I fully understand the maintaining issue here. I will outsource it to another repository than to allow others to use / copy / extend it by need.
Thank you guys for all your work!

lookyman reacted with thumbs up emoji

Copy link
Author

For anyone interested in such a feature - here's the package:
https://packagist.org/packages/dadadev/phpstan-symfony-routing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /