Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use spaces instead of tabs in config example #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robertfausk wants to merge 1 commit into phpstan:master from robertfausk:patch-1

Conversation

@robertfausk
Copy link

@robertfausk robertfausk commented Oct 24, 2018

of phpstan.neon cause tabs are not allowed and will result in an error after c&p this example and running phpstan.

Error message example:

Note: Using configuration file /var/www/html/phpstan.neon.dist.
In Decoder.php line 357:
 
 Invalid combination of tabs and spaces on line 7, column 9. 

of phpstan.neon cause tabs are not allowed and will result in an error after c&p this example and running phpstan.
Error message example:
```
Note: Using configuration file /var/www/html/phpstan.neon.dist.
In Decoder.php line 357:
 
 Invalid combination of tabs and spaces on line 7, column 9. 
```
Copy link
Member

In NEON tabs are allowed but you can't mix them with spaces.

Copy link
Member

So it doesn't make sense to merge this, someone might bump into an opposite issue.

lookyman reacted with thumbs up emoji

Copy link
Author

What do you think about leaving a hint next to this example that copy & paste can lead to an error (as happened to me)?

Copy link
Member

I think the message is self-evident and is easy to fix so there doesn’t have to be a notice in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /