Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Enhancement: Cache dependencies installed with composer between builds #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 1 commit into phpstan:master from localheinz:feature/cache
Feb 9, 2019

Conversation

@localheinz
Copy link
Contributor

@localheinz localheinz commented Jan 19, 2019

This PR

  • caches dependencies installed with composer between builds


cache:
directories:
- $HOME/.composer/cache
Copy link

@kubawerlos kubawerlos Jan 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not $HOME/.composer? And then hirak/prestissimo in before_install.

Copy link
Member

@ondrejmirtes ondrejmirtes Jan 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't complicate it with that, cache is enough.

dereuromark reacted with thumbs up emoji
Copy link
Contributor

@dereuromark dereuromark Jan 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even this whole cache doesnt really provide too much speed benefit actually, composer already caches a lot internally.

Copy link
Member

Thanks!

@ondrejmirtes ondrejmirtes merged commit cda85d5 into phpstan:master Feb 9, 2019
@localheinz localheinz deleted the feature/cache branch February 9, 2019 13:05
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes left review comments

+2 more reviewers

@dereuromark dereuromark dereuromark left review comments

@kubawerlos kubawerlos kubawerlos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /