-
Notifications
You must be signed in to change notification settings - Fork 545
Resolve remaining predefined constants #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve remaining predefined constants #693
Conversation
What do you think @ondrejmirtes and what about the remaining open conversations @staabm?
97c2f21 to
a03a78f
Compare
rebased and cleaned up a bit
Hi, I really don’t want to read 64 comments. Anything worth my attention before I review? 😊
Sorry for spaming you with the rebases (wanted to make the CI green again) :/
Most of it was about the PHP version constants (should we have upper limits or not). So a look/check/special think there might be worth when reviewing. The rest is resolved.
This resolves the remaining predefined constants that are configured via `dynamicConstantNames` and differ from what reflection is able to resolve.
Thank you!
thx, I hope this doesn't introduce annoying new errors 🤞
I’ll /cc you if it does 😊
Uh oh!
There was an error while loading. Please reload this page.
Follow-up of #684
This resolves the remaining predefined constants that are configured via
dynamicConstantNamesand differ from what reflection is able to resolve.There are a few constants that are defined via compilation flags where I was not a 100% sure if they can be empty or not.
And, of course, there would be many more constants from extensions that could be defined potentially and the resolving code could be refactored or grouped differently, but for now I wanted to keep it simple and adapt it based on the feedback I get.
Currently it's grouped/sorted like the following with links to docs