-
Notifications
You must be signed in to change notification settings - Fork 545
Range with strings #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'd like the suggested logic from phpstan/phpstan#2378 (comment). These if statements won't cover all cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this isn't at all how dynamic return type extensions are tested. Please add new dataProvider to NodeScopeResolverTest::testFileAsserts and test it there. THank you.
Please open the PR again if you decide to finish it. Thanks.
Fixes phpstan/phpstan#2378