Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove wrong return type of imagejpeg GD function #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 1 commit into phpstan:master from MauricioFauth:imagejpeg-return-type
Aug 12, 2021

Conversation

@MauricioFauth
Copy link
Contributor

@MauricioFauth MauricioFauth commented Aug 9, 2021

The return type of the imagejpeg function is bool not false|string.

 imagejpeg(GdImage $image, resource|string|null $file = null, int $quality = -1): bool

Introduced by #265 and not removed by #277.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@ondrejmirtes ondrejmirtes merged commit 07c542f into phpstan:master Aug 12, 2021
Copy link
Member

Thank you.

MauricioFauth reacted with rocket emoji

@MauricioFauth MauricioFauth deleted the imagejpeg-return-type branch August 12, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /