-
Notifications
You must be signed in to change notification settings - Fork 545
Add uopz 6.x functions #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be misunderstanding this, but currently PHPStan is complaining that Parameter #3 $static of function uopz_set_return expects array while parameter #3 is actually the value in the following form:
https://github.com/krakjoe/uopz/blob/v6.1.2/uopz.c#L185-L186
uopz_set_return ( string $class , string $function , mixed $value , bool $execute = false ) : bool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SMillerDev Hi, this is a pretty old PR. If you see a buggy behaviour, please open an issue with reproduction, thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do, thanks.
SMillerDev
commented
May 19, 2021
@ondrejmirtes I don't think this does what it's supposed to actually.
refs https://github.com/krakjoe/uopz/blob/v6.1.2/uopz.c
The parameters in the PHP manual are different from the implementation.