Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

make BcMath\Number::$value numeric-string #4505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 1 commit into phpstan:2.1.x from schlndh:fix-bcMathNumberValueType
Oct 31, 2025

Conversation

@schlndh
Copy link
Contributor

@schlndh schlndh commented Oct 31, 2025 •
edited
Loading

Fixes https://phpstan.org/r/da494451-a17d-49f9-bcb7-5b2ce11219d2

It's covered by ReflectionProviderGoldenTest so I didn't add any other test:

1) PHPStan\Reflection\ReflectionProviderGoldenTest::test with data set "PROPERTY BcMath\Number::$value" ('PROPERTY BcMath\Number::$value', 'Readonly\nVisibility: public\...string')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 'Readonly
 Visibility: public
-Read type: string
-Write type: string'
+Read type: numeric-string
+Write type: numeric-string'

@ondrejmirtes ondrejmirtes merged commit ae9d277 into phpstan:2.1.x Oct 31, 2025
540 of 555 checks passed
Copy link
Member

Thank you!
schlndh reacted with thumbs up emoji

@schlndh schlndh deleted the fix-bcMathNumberValueType branch October 31, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /