-
Couldn't load subscription status.
- Fork 544
feat: isEnum class-string narrowing #4474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems many of the failures are not related to my changes....
yes, atm a few spurious errors are in CI.
these here are related though: https://github.com/phpstan/phpstan-src/actions/runs/18773626957/job/53563151392?pr=4474
I'll have another look after the weekend, for now any annotation I add seems to have no effect on the asserted type.
It feels like the annotations in the ReflectionClass.stub file are ignored.
/** * @return false */ public function isEnum(): bool { }
Failed assertions in /projects/phpstan-src/tests/PHPStan/Analyser/nsrt/reflectionclass-isEnum.php:
Line 13:
Expected: false
Actual: bool
Is there some kind of build step for the stubs that i'm missing?
There's no build step for stubs. I don't know why it does not work for you but I'd argue that:
/** * @return false */ public function isEnum(): bool { }
is wrong: https://3v4l.org/AZfkh
It is wrong 100%, but my objective here was to test if the annotation is working at all.
The simplest annotation I could think of was @return false....
And if this already doesn't work I need to figure that part out first before I test my actual more complex annotations...
Do not forget to also update ReflectionClassWithLazyObjects.stub.
Do not forget to also update ReflectionClassWithLazyObjects.stub.
That was the cause, I did not realize there are 2 stubs for this class. Thanks, now I can get to work on the actual implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion does not work currently. Is there anyway to narrow the type T for a generic?
I've tried using @phsptan-assert-if-true UnitEnum T, but that doesn't work.
Current implementation works! I'd like to actually narrow the class (template type T) of the reflection object as well, but that doesn't seem to work yet.
Implements phpstan/phpstan#13712