Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix crashes in ParametersAcceptorSelector #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 1 commit into phpstan:2.1.x from staabm:bug13714
Oct 23, 2025

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Oct 23, 2025

@staabm staabm marked this pull request as ready for review October 23, 2025 11:45
Copy link
Collaborator

This pull request has been marked as ready for review.

public function testBug13714(): void
{
$errors = $this->runAnalyse(__DIR__ . '/data/bug-13714.php');
$this->assertCount(19, $errors);
Copy link
Member

@ondrejmirtes ondrejmirtes Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the 19 errors? Can you produce code that makes PHPStan crash but once fixed, it produces no errors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no errors seems hard todo, but I reduced it to a minimum

@ondrejmirtes ondrejmirtes merged commit 3435c3b into phpstan:2.1.x Oct 23, 2025
541 of 551 checks passed
Copy link
Member

Awesome, thank you!

@staabm staabm deleted the bug13714 branch October 23, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

crash when scoper using projects is loaded

AltStyle によって変換されたページ (->オリジナル) /