-
Couldn't load subscription status.
- Fork 544
TypeCombinatorTest: turn return into yield
#4451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been marked as ready for review.
please do not merge yet, as I need to tripple check the results first. I was just asking for the idea at first
I'm thinking:
- I don't want to merge this before we merge and test and release the new PHPUnit rule. I want to see what it does with the current test suite as it has existed for years.
- I want to eventually do this but with a custom rule here in phpstan-src that uses fixNode() to do this. I don't want to do it once with Rector and then get it wrong again, I want to continuously test it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
I used rector to transform the test. I think its way more readable to have a single
yieldper test-case instead of a hugereturn [[], [], []]in which its hard to see where test-data from one test starts and where the next one starts etc.just did the transformation on a single test for now, to discuss the overall idea.
this PR did not transform the
yield from [[], [], []]intoyield, as this is not yet implemented in rector.wdyt?