Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix too wide bool in trivial methods #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
staabm wants to merge 10 commits into phpstan:2.1.x
base: 2.1.x
Choose a base branch
Loading
from staabm:bug13482
Open

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Oct 16, 2025

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've deleted a bunch of test assertions. Right now there are vast areas of the code that aren't covered by proper tests.

What needs to happen first is to change the current tests so they continue to be reported.

Then you can add your own tests for code that shouldn't be reported. Thanks.

@staabm staabm force-pushed the bug13482 branch 2 times, most recently from b1c88e0 to e1b8456 Compare October 17, 2025 16:12
Copy link
Contributor Author

staabm commented Oct 17, 2025

@ondrejmirtes great feedback thanks. adjusted the tests accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

too wide bool in trivial methods

AltStyle によって変換されたページ (->オリジナル) /