-
Notifications
You must be signed in to change notification settings - Fork 545
Add stream_socket_{client,server} stubs for @param-out
#4391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
ondrejmirtes
requested changes
Sep 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files need to be registered in stubFiles in conf/config.neon.
@msbit
msbit
force-pushed
the
stubs-stream-socket
branch
from
September 29, 2025 14:25
54361ed to
9154b75
Compare
@msbit
msbit
force-pushed
the
stubs-stream-socket
branch
from
September 29, 2025 14:31
9154b75 to
1038814
Compare
Okay @ondrejmirtes, it appears the remaining failed tests are unrelated?
@ondrejmirtes
ondrejmirtes
merged commit Sep 29, 2025
d5f3f7e
into
phpstan:2.1.x
544 of 549 checks passed
Thank you!
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to fix:
stream_socket_clientreference arguments’ type are ignored phpstan#12622