Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Added proc_open() stub for param-out #4261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 11 commits into phpstan:2.1.x from staabm:proc
Sep 19, 2025
Merged

Added proc_open() stub for param-out #4261

ondrejmirtes merged 11 commits into phpstan:2.1.x from staabm:proc
Sep 19, 2025

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Aug 26, 2025 •
edited
Loading

jlherren reacted with heart emoji
@staabm staabm marked this pull request as ready for review August 26, 2025 09:39
Copy link
Collaborator

This pull request has been marked as ready for review.

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're closing an issue, please add a regression test for https://phpstan.org/r/dc1d4f91-b22d-4eaa-b796-34a353062477

Copy link
Member

(I don't think the issue is solved so that's why I'm asking for a test for the new behaviour)

Copy link
Contributor Author

staabm commented Aug 30, 2025

@ondrejmirtes test added. I think it works.

@ondrejmirtes ondrejmirtes merged commit e4e21c7 into phpstan:2.1.x Sep 19, 2025
455 of 457 checks passed
@staabm staabm deleted the proc branch September 19, 2025 12:22
Copy link
Contributor

Thank you @staabm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

+1 more reviewer

@mvorisek mvorisek mvorisek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PHPStan does not understand proc_open Assign to property by reference ignores functionMap.php

AltStyle によって変換されたページ (->オリジナル) /