Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: add options to report ignores without identifiers or comments #3976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calebdw wants to merge 2 commits into phpstan:2.1.x
base: 2.1.x
Choose a base branch
Loading
from calebdw:calebdw/push-qtlvsunynsrq

Conversation

@calebdw
Copy link
Contributor

@calebdw calebdw commented Apr 30, 2025 •
edited
Loading

Hello!

Closes phpstan/phpstan#11340

This PR adds the following two options (false by default):

  • reportIgnoresWithoutIdentifiers: reports @phpstan-ignore-line and @phpstan-ignore-next-line usages
  • reportIgnoresWithoutComments: reports @phpstan-ignore usages without comments

Thanks!

NanoSector reacted with hooray emoji
@calebdw calebdw force-pushed the calebdw/push-qtlvsunynsrq branch from 94bcb68 to 47d8329 Compare April 30, 2025 18:29
Copy link
Contributor Author

calebdw commented Apr 30, 2025

CI failures look to be unrelated

@calebdw calebdw changed the title (削除) feat: add option to report ignores without identifiers (削除ここまで) (追記) feat: add options to report ignores without identifiers or comments (追記ここまで) Apr 30, 2025
@calebdw calebdw force-pushed the calebdw/push-qtlvsunynsrq branch 2 times, most recently from 384c8af to 0475ff1 Compare April 30, 2025 21:05
Copy link

Thanks for providing this & also picking up the case for no comments 🙌
calebdw reacted with thumbs up emoji

@calebdw calebdw force-pushed the calebdw/push-qtlvsunynsrq branch from 0475ff1 to a63175b Compare May 10, 2025 21:44
@calebdw calebdw force-pushed the calebdw/push-qtlvsunynsrq branch 2 times, most recently from e976b0d to 8e4e5f8 Compare May 22, 2025 12:25
@calebdw calebdw force-pushed the calebdw/push-qtlvsunynsrq branch from 8e4e5f8 to 2a4b464 Compare May 29, 2025 13:04
@calebdw calebdw force-pushed the calebdw/push-qtlvsunynsrq branch 3 times, most recently from ae45feb to 3b7dc03 Compare June 21, 2025 04:43
@calebdw calebdw force-pushed the calebdw/push-qtlvsunynsrq branch from 3b7dc03 to 3154768 Compare July 14, 2025 18:54
@calebdw calebdw force-pushed the calebdw/push-qtlvsunynsrq branch from 3154768 to e36cd48 Compare September 13, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Option to disable phpstan-ignore-line and phpstan-ignore-next-line

AltStyle によって変換されたページ (->オリジナル) /