Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix a few regex class parsing usecases #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 8 commits into phpstan:1.12.x from mvorisek:fix_delim_remove_regex
Oct 6, 2024

Conversation

@mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Sep 26, 2024 •
edited
Loading

No description provided.

@mvorisek mvorisek force-pushed the fix_delim_remove_regex branch 3 times, most recently from b069a8b to dc514ed Compare September 26, 2024 11:52
@mvorisek mvorisek marked this pull request as ready for review September 26, 2024 12:04
Copy link
Collaborator

This pull request has been marked as ready for review.

@mvorisek mvorisek marked this pull request as draft September 26, 2024 17:11
@mvorisek mvorisek changed the title (削除) Fix delimiter unescape when removing from regex (削除ここまで) (追記) Add a few backslash regex tests (追記ここまで) Sep 26, 2024
@mvorisek mvorisek changed the title (削除) Add a few backslash regex tests (削除ここまで) (追記) Fix "]" first char parsing in class regex (追記ここまで) Sep 26, 2024
@mvorisek mvorisek marked this pull request as ready for review September 26, 2024 22:38
Copy link
Collaborator

This pull request has been marked as ready for review.

@mvorisek mvorisek force-pushed the fix_delim_remove_regex branch 2 times, most recently from 6c07966 to 93e2709 Compare September 26, 2024 23:14
Copy link
Contributor

@Seldaek Seldaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the two tests that should be changed and bug fixed (but maybe @staabm can take a look in a follow-up PR as he's probably more familiar with that code), the changes here look good to me now 👍🏻

@mvorisek mvorisek changed the title (削除) Fix "]" first char parsing in class regex (削除ここまで) (追記) Fix a few regex class parsing usecases (追記ここまで) Sep 27, 2024
Copy link
Contributor

Seldaek commented Sep 27, 2024

Cool, thanks for the last couple fixes 👍🏻

Copy link
Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Copy link
Contributor Author

@ondrejmirtes can this PR be merged?

Copy link
Member

@mvorisek It's been only 4 days since you opened it. Don't be needy.

@ondrejmirtes ondrejmirtes merged commit a9ec512 into phpstan:1.12.x Oct 6, 2024
481 of 499 checks passed
Copy link
Member

Thank you.

@mvorisek mvorisek deleted the fix_delim_remove_regex branch October 6, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@staabm staabm staabm approved these changes

@Seldaek Seldaek Seldaek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /