-
Notifications
You must be signed in to change notification settings - Fork 545
fix !== with union of constants #2700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ondrejmirtes
merged 2 commits into
phpstan:1.10.x
from
schlndh:fix-nonIdenticalConstantUnion
Oct 29, 2023
Merged
fix !== with union of constants #2700
ondrejmirtes
merged 2 commits into
phpstan:1.10.x
from
schlndh:fix-nonIdenticalConstantUnion
Oct 29, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
staabm
reviewed
Oct 27, 2023
Somehow this results in the following undesired change for https://phpstan.org/r/6f38a4ed-ff07-4959-9689-7d854de5f0ae 🤔
@@ @@
+PHP 7.4 – 8.3 (1 error)
+==========
+
+26: Expected type string, actual: bool|float|int|string
+
+PHP 7.2 – 7.3 (3 errors)
+==========
+
+24: Class PHPStan\Type\Constant\ConstantStringType not found.
+26: Call to method getValue() on an unknown class PHPStan\Type\Constant\ConstantStringType.
26: Expected type string, actual: bool|float|int|string
I think its a unrelated side-effect. the playground sometime reports errors when you use PHPStan internal classes within the snippet
ondrejmirtes
ondrejmirtes
requested changes
Oct 27, 2023
@schlndh
schlndh
force-pushed
the
fix-nonIdenticalConstantUnion
branch
from
October 27, 2023 12:54
9fa90af to
39a1890
Compare
staabm
staabm
reviewed
Oct 27, 2023
@schlndh
schlndh
force-pushed
the
fix-nonIdenticalConstantUnion
branch
from
October 27, 2023 13:38
f99e852 to
82d9931
Compare
@ondrejmirtes
ondrejmirtes
force-pushed
the
fix-nonIdenticalConstantUnion
branch
from
October 29, 2023 07:37
82d9931 to
bc8ee00
Compare
ondrejmirtes
ondrejmirtes
approved these changes
Oct 29, 2023
Awesome, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#10002