Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Added text regarding patch issues during installation #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 2 commits into phpstan:1.11.x from mt-satak:fix_readme_installation
Oct 9, 2023

Conversation

@mt-satak
Copy link
Contributor

@mt-satak mt-satak commented Oct 9, 2023 •
edited
Loading

Why did I submit this PR?

When performing composer install, the patch to hoa/protocol failed to apply.

 - Applying patches for hoa/protocol
 patches/Node.patch (0)
 Could not apply patch! Skipping. The error was: The process "patch '-p1' --no-backup-if-mismatch -d '/Users/satak/dev/phpstan-src/vendor/hoa/protocol' < '/Users/satak/dev/phpstan-src/patches/Node.patch'" exceeded the timeout of 300 seconds.
In Patches.php line 331:
 
 Cannot apply patch 0 (patches/Node.patch)!

This error is caused by an out-of-date version of patch pre-installed on macOS, and can be resolved by doing brew install gpatch before running composer install to bring it up to date.

Purpose of this PR

To add the above solution to the README to leave a clue for solving similar errors when they occur.

Copy link
Collaborator

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

@ondrejmirtes ondrejmirtes merged commit 6252d21 into phpstan:1.11.x Oct 9, 2023
Copy link
Member

Thank you.
mt-satak and togishima reacted with heart emoji

@mt-satak mt-satak deleted the fix_readme_installation branch October 9, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /