-
Notifications
You must be signed in to change notification settings - Fork 545
Skip not deprecated methods #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yes, you’re right, thanks, but we should really cover this with a test too 😊 Thanks.
BTW I want to give you some guidance how to implement the friend method stuff, in my mind there aren’t even needed any changes for the phpdoc-parser 😊 Please wait a few moments, I’ll find some time tonight.
e1b3ac2 to
4a56ca5
Compare
4a56ca5 to
4cf932c
Compare
we should really cover this with a test too
Here you go!
BTW I want to give you some guidance how to implement the friend method stuff
Thank you very much! I'll gladly compare your way with guesses I made today :D
Thank you, perfect! I'll describe it in phpstan/phpstan#3565.
While roaming around the codebase I have found these two places that seem to not work correctly. Looks like no test was asserting the result so the question is whether shall I write one?