-
Couldn't load subscription status.
- Fork 544
Make int ranges generic #2642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make int ranges generic #2642
Conversation
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder - do we need a new GenericIntegerRangeType for this? Other types have a similar capability out of the box. Can we just change IntegerRangeType to support this?
I did consider that option, but given that IntegerRangeType is public api and requires ?int bounds, it didn't seem viable to me.
@rvanvelzen Can we make a new IntegerRangeType, deprecate the old one, and start using the new one everywhere? In 2.0 I'd just renamed the new one to the current IntegerRangeType name.
Fix phpstan/phpstan#6810