-
Notifications
You must be signed in to change notification settings - Fork 545
phpcs: use parallel mode #2049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phpcs: use parallel mode #2049
Conversation
What improvement does this give? And does GitHub Actions provide more than one core to run this in parallel during CI?
github actions run with 2 cores on the default instance. whether its a measurable difference need to be proved though.
@theofidry maybe phpcs should have some cpu core autodetection ;)
What improvement does this give?
Minor CI & local speedup.
maybe phpcs should have some cpu core autodetection ;)
Yeah, ideally. Current solution is really naive.
I dont really care about this PR much, but it feels wrong not to utilize faster solution :)
alies-dev
commented
Dec 25, 2022
What improvement does this give? And does GitHub Actions provide more than one core to run this in parallel during CI?
GH provides 2, 4, 8, 16, 64 core runners, also supports custom runners: https://docs.github.com/en/actions/using-github-hosted-runners/using-larger-runners
I see this PR very beneficial - I can remove some custom core that I wrote to utility all CPUs for different tools
a5d90c1 to
a69c7f0
Compare
Uh oh!
There was an error while loading. Please reload this page.
Ideally, available vcpus should be used...