Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow symfony 5 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fezfez wants to merge 1 commit into phpstan:master from fezfez:symfony5
Closed

Allow symfony 5 #20

fezfez wants to merge 1 commit into phpstan:master from fezfez:symfony5

Conversation

@fezfez
Copy link

@fezfez fezfez commented Nov 21, 2019

No description provided.

Copy link
Member

This isn’t neccesary. PHPStan 0.12 in phpstan/phpstan package won’t have the dependency on Symfony.

If it’s a blocker for you right now, install the current stable version of phpstan/phpstan-shim.

Copy link
Author

fezfez commented Nov 24, 2019

@ondrejmirtes thanks for the quick response, Have you scheduled a date for the version?

Copy link
Member

Yes, December 3rd.

Copy link

emodric commented Nov 25, 2019
edited
Loading

@ondrejmirtes 0.11.19 release of phpstan/phpstan does not allow Symfony 5.0. Could 0.11.20 be tagged which allows Symfony 5 for projects that will not upgrade to PhpStan 0.12 right away?

Copy link
Member

Copy link

emodric commented Nov 25, 2019

@ondrejmirtes I'm sorry if I'm missunderstanding something, but how do I use rule packs (like strict rules or phpunit rules) with the shim package, since they all depend on phpstan/phpstan?

Copy link
Member

ondrejmirtes commented Nov 25, 2019 via email

You use them exactly the same way, try it ;)
On 2019年11月25日 at 16:17, Edi Modrić ***@***.***> wrote: @ondrejmirtes <https://github.com/ondrejmirtes> I'm sorry if I'm missunderstanding something, but how do I use rule packs (like strict rules or phpunit rules) with the shim package, since they all depend on phpstan/phpstan? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20?email_source=notifications&email_token=AAAZTOHEBTGIMPAX2TQU6NTQVPT7HA5CNFSM4JQAPFV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFCXPRQ#issuecomment-558200774>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZTOD4N7LDKR3LKOZY3FLQVPT7HANCNFSM4JQAPFVQ> .
-- Ondřej Mirtes

Copy link

emodric commented Nov 25, 2019

Oh, the shim package replaces phpstan/phpstan in Composer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /