Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Tagged unions #1547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 1 commit into 1.8.x from tagged-unions
Aug 27, 2022
Merged

Tagged unions #1547

ondrejmirtes merged 1 commit into 1.8.x from tagged-unions
Aug 27, 2022

Conversation

@ondrejmirtes
Copy link
Member

@ondrejmirtes ondrejmirtes commented Jul 25, 2022

No description provided.

canvural, rvanvelzen, and arnaud-lb reacted with rocket emoji
@ondrejmirtes ondrejmirtes marked this pull request as ready for review August 27, 2022 06:33
@ondrejmirtes ondrejmirtes merged commit 40043e9 into 1.8.x Aug 27, 2022
@ondrejmirtes ondrejmirtes deleted the tagged-unions branch August 27, 2022 06:33
@ondrejmirtes ondrejmirtes changed the title (削除) WIP: Tagged unions (削除ここまで) (追記) Tagged unions (追記ここまで) Aug 27, 2022
Copy link
Contributor

herndlm commented Aug 27, 2022

I did not look into it before at all, but I'm amazed by how small the actual changes in this PR are. you did quite some precondition work already before though, right?

Copy link
Member Author

Before the vacation I commited this #1548 which famously fixed something like 18 issues 😅

On vacation I could not stop thinking about this and during the afternoon break when kids were asleep I couldn't help myself but do something about problems the previous code uncovered.

I've been fixing various related bugs, and the CI has been finally green last two days or so 😅 This dev cycle has been challenging to say the least.

Some of the notable fixes are:

canvural, herndlm, staabm, drupol, ZebulanStanphill, mad-briller, allan-simon, and arnaud-lb reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /