Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add reformat command #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Erikvv wants to merge 2 commits into phpstan:master from Erikvv:deserialize-json
Closed

Add reformat command #147

Erikvv wants to merge 2 commits into phpstan:master from Erikvv:deserialize-json

Conversation

@Erikvv
Copy link

@Erikvv Erikvv commented Feb 28, 2020 •
edited
Loading

What's this?

Add command to transform json output into other formats.
This allows to do 1 run, and then produce different outputs.
This saves some compute resources for large projects.

Example:

phpstan analyse --error-format json src/ > output.json
cat output.json | phpstan reformat --error-format table > output.txt
cat output.json | phpstan reformat --error-format baselineNeon > baseline.neon

Testing

staabm reacted with rocket emoji
@Erikvv Erikvv changed the title (削除) Add reformat command (削除ここまで) (追記) [WIP] Add reformat command (追記ここまで) Feb 28, 2020
Copy link
Member

Yes! 😍 I had this in my todolist :)

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus fix the build failures. Thank you.

Copy link
Author

Erikvv commented Feb 28, 2020

Thanks for your feedback I addressed it all.

@Erikvv Erikvv changed the title (削除) [WIP] Add reformat command (削除ここまで) (追記) Add reformat command (追記ここまで) Feb 28, 2020
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more fixes to do :)

Copy link
Author

Erikvv commented Mar 13, 2020

Sorry for delay, I was having some time off.

Rebased and feedback processed.

@ondrejmirtes ondrejmirtes force-pushed the master branch 5 times, most recently from dc2e229 to 1d0d3ad Compare March 17, 2020 14:14
Copy link
Author

Erikvv commented Apr 24, 2020

@ondrejmirtes any chance this can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /