Commit 5e4c5d8

committed

Only report maybe cases at level 7

1 parent c2c2b88 commit 5e4c5d8Copy full SHA for 5e4c5d8

File tree

2 files changed

+19

-8

lines changed

conf
- config.level5.neon
src/Rules/Functions
- RandomIntParametersRule.php

2 files changed

+19

-8

lines changed

`‎conf/config.level5.neon‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,3 +14,5 @@ parameters:`
`14`	`14`	`services:`
`15`	`15`	`-`
`16`	`16`	`class: PHPStan\Rules\Functions\RandomIntParametersRule`
	`17`	`+ arguments:`
	`18`	`+ reportMaybes: %reportMaybes%`

`‎src/Rules/Functions/RandomIntParametersRule.php‎`

Lines changed: 17 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,9 +21,13 @@ class RandomIntParametersRule implements \PHPStan\Rules\Rule`
`21`	`21`	`/** @var ReflectionProvider */`
`22`	`22`	`private $reflectionProvider;`
`23`	`23`
`24`		`- public function __construct(ReflectionProvider $reflectionProvider)`
	`24`	`+ /** @var bool */`
	`25`	`+ private $reportMaybes;`
	`26`	`+`
	`27`	`+ public function __construct(ReflectionProvider $reflectionProvider, bool $reportMaybes)`
`25`	`28`	`{`
`26`	`29`	`$this->reflectionProvider = $reflectionProvider;`
	`30`	`+ $this->reportMaybes = $reportMaybes;`
`27`	`31`	`}`
`28`	`32`
`29`	`33`	`public function getNodeType(): string`
`@@ -59,13 +63,18 @@ public function processNode(Node $node, Scope $scope): array`
`59`	`63`	`if (!$maxPermittedType->isSuperTypeOf($maxType)->yes()) {`
`60`	`64`	`$message = 'Parameter #1 $min (%s) of function random_int expects lower number than parameter #2 $max (%s).';`
`61`	`65`
`62`		`- return [`
`63`		`- RuleErrorBuilder::message(sprintf(`
`64`		`- $message,`
`65`		`- $minType->describe(VerbosityLevel::value()),`
`66`		`- $maxType->describe(VerbosityLevel::value())`
`67`		`- ))->build(),`
`68`		`- ];`
	`66`	`+ // True if sometimes the parameters conflict.`
	`67`	`+ $isMaybe = !$maxType->isSuperTypeOf($minType)->no();`
	`68`	`+`
	`69`	`+ if (!$isMaybe \|\| $this->reportMaybes) {`
	`70`	`+ return [`
	`71`	`+ RuleErrorBuilder::message(sprintf(`
	`72`	`+ $message,`
	`73`	`+ $minType->describe(VerbosityLevel::value()),`
	`74`	`+ $maxType->describe(VerbosityLevel::value())`
	`75`	`+ ))->build(),`
	`76`	`+ ];`
	`77`	`+ }`
`69`	`78`	`}`
`70`	`79`	`}`
`71`	`80`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 5e4c5d8

File tree

2 files changed

2 files changed

`‎conf/config.level5.neon‎`

`‎src/Rules/Functions/RandomIntParametersRule.php‎`

0 commit comments