Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit c2c2b88

Browse files
committed
Change error message for consistency
1 parent dec9c89 commit c2c2b88

File tree

2 files changed

+11
-15
lines changed

2 files changed

+11
-15
lines changed

‎src/Rules/Functions/RandomIntParametersRule.php‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,7 @@ public function processNode(Node $node, Scope $scope): array
5757
}
5858

5959
if (!$maxPermittedType->isSuperTypeOf($maxType)->yes()) {
60-
$message = 'Cannot call random_int() when $min parameter (%s) can be greater than $max parameter (%s).';
61-
62-
if ($maxType->isSuperTypeOf($minType)->no()) {
63-
$message = 'Cannot call random_int() when $min parameter (%s) is greater than $max parameter (%s).';
64-
}
60+
$message = 'Parameter #1 $min (%s) of function random_int expects lower number than parameter #2 $max (%s).';
6561

6662
return [
6763
RuleErrorBuilder::message(sprintf(

‎tests/PHPStan/Rules/Functions/RandomIntParametersRuleTest.php‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,46 +10,46 @@ class RandomIntParametersRuleTest extends \PHPStan\Testing\RuleTestCase
1010

1111
protected function getRule(): \PHPStan\Rules\Rule
1212
{
13-
return new RandomIntParametersRule($this->createReflectionProvider());
13+
return new RandomIntParametersRule($this->createReflectionProvider(), true);
1414
}
1515

1616
public function testFile(): void
1717
{
1818
$this->analyse([__DIR__ . '/data/random-int.php'], [
1919
[
20-
'Cannot call random_int() when $min parameter (1) is greater than $max parameter (0).',
20+
'Parameter #1 $min (1) of function random_int expects lower number than parameter #2 $max (0).',
2121
8,
2222
],
2323
[
24-
'Cannot call random_int() when $min parameter (0) is greater than $max parameter (-1).',
24+
'Parameter #1 $min (0) of function random_int expects lower number than parameter #2 $max (-1).',
2525
9,
2626
],
2727
[
28-
'Cannot call random_int() when $min parameter (0) is greater than $max parameter (int<-10, -1>).',
28+
'Parameter #1 $min (0) of function random_int expects lower number than parameter #2 $max (int<-10, -1>).',
2929
11,
3030
],
3131
[
32-
'Cannot call random_int() when $min parameter (0) can be greater than $max parameter (int<-10, 10>).',
32+
'Parameter #1 $min (0) of function random_int expects lower number than parameter #2 $max (int<-10, 10>).',
3333
12,
3434
],
3535
[
36-
'Cannot call random_int() when $min parameter (int<1, 10>) is greater than $max parameter (0).',
36+
'Parameter #1 $min (int<1, 10>) of function random_int expects lower number than parameter #2 $max (0).',
3737
15,
3838
],
3939
[
40-
'Cannot call random_int() when $min parameter (int<-10, 10>) can be greater than $max parameter (0).',
40+
'Parameter #1 $min (int<-10, 10>) of function random_int expects lower number than parameter #2 $max (0).',
4141
16,
4242
],
4343
[
44-
'Cannot call random_int() when $min parameter (int<-5, 1>) can be greater than $max parameter (int<0, 5>).',
44+
'Parameter #1 $min (int<-5, 1>) of function random_int expects lower number than parameter #2 $max (int<0, 5>).',
4545
19,
4646
],
4747
[
48-
'Cannot call random_int() when $min parameter (int<-5, 0>) can be greater than $max parameter (int<-1, 5>).',
48+
'Parameter #1 $min (int<-5, 0>) of function random_int expects lower number than parameter #2 $max (int<-1, 5>).',
4949
20,
5050
],
5151
[
52-
'Cannot call random_int() when $min parameter (int<0, 10>) can be greater than $max parameter (int<0, 10>).',
52+
'Parameter #1 $min (int<0, 10>) of function random_int expects lower number than parameter #2 $max (int<0, 10>).',
5353
31,
5454
],
5555
]);

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /