-
Notifications
You must be signed in to change notification settings - Fork 50
Use TypeSystem in AssertSameBooleanExpectedRule #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another case in which infection made me add new tests:
grafik
I disagree with this. I feel like that when someones does:
$this->assertSame(Foo::BAR, $expected);
It's there on purpose and it means "expected should be the same as Foo::BAR". The value of Foo::BAR might be true right now but it's there so that the value can change.
Changing the code to:
$this->assertTrue($expected);
would lose information.
ok. reduced it to the new tests
remaining tests are here to kill mutants
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
I think it makes sense that we get the same error when working with constants and known value.
phpstan-phpunit/tests/Rules/PHPUnit/data/assert-same-boolean-expected.php
Lines 29 to 33 in 450bfc0