Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add missing methods that generate mocks #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 1 commit into phpstan:master from lcobucci:add-missing-methods
Dec 11, 2017

Conversation

@lcobucci
Copy link
Contributor

@lcobucci lcobucci commented Dec 10, 2017

Some methods were missing, and when used phpstan doesn't work properly. It shows errors like:

Property MyTest::$property (MockedClass&PHPUnit\Framework\MockObject\MockObject) does not accept PHPUnit\Framework\MockObject\MockObject. 

This PR fixes it, but I didn't add any test (since the repo doesn't have any)

- `createPartialMock()` is available since PHPUnit 5.5.0
- `createTestProxy()` is available since PHPUnit 6.0.0
Copy link
Member

Thank you! 👍

lcobucci reacted with thumbs up emoji

@ondrejmirtes ondrejmirtes merged commit 96d2421 into phpstan:master Dec 11, 2017
@lcobucci lcobucci deleted the add-missing-methods branch December 11, 2017 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /