-
Notifications
You must be signed in to change notification settings - Fork 112
Implemented Doctrine\DBAL\Types\Type::getType handling
#70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This service can be marked only with - (because it's very unlikely someone will want to override it) and moved above to other anonymous - services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to ask for $scope->getType($dbalTypeArg) and check against ConstantStringType.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file isn't mentioned/tested anywhere?
Closing abandoned PR.
No description provided.