Add deprecations errors for functions typehints #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ondrejmirtes merged 4 commits into phpstan:master from paxal:typehint_function_signature

Jul 25, 2019

Merged

Add deprecations errors for functions typehints #15

ondrejmirtes merged 4 commits into phpstan:master from paxal:typehint_function_signature

Jul 25, 2019

Conversation

@paxal

Copy link

Contributor

@paxal paxal commented Jun 26, 2019

Add deprecations errors for functions typehints ‒ InFunctionNode
Also make errors prettier for anonymous class in deprecations for class method typehints

@paxal paxal force-pushed the typehint_function_signature branch from ee435ce to ebf68c2 Compare

July 23, 2019 09:50

@paxal

Copy link

Contributor Author

paxal commented Jul 23, 2019

I've added closures as discussed here #13 (comment)

ondrejmirtes

ondrejmirtes requested changes

Jul 23, 2019

View reviewed changes

Copy link

Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good! I've found a few minor issues but otherwise this is great! 👍

src/Rules/Deprecations/TypeHintDeprecatedInFunctionSignatureRule.php Outdated

return [];

}

/** @var FunctionReflection $function */

Copy link

Member

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line with @var does not have to be here if we have that if right below.

src/Rules/Deprecations/TypeHintDeprecatedInFunctionSignatureRule.php Outdated

$errors = [];

foreach ($functionSignature->getParameters() as $i => $parameter) {

/** @var ParameterReflection $parameter */

Copy link

Member

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this @var has to exist - $functionSignature->getParameters() is already properly annotated.

src/Rules/Deprecations/TypeHintDeprecatedInFunctionSignatureRule.php Outdated

private function getClassDeprecationDescription(ClassReflection $class): string

{

$description = null;

if (method_exists($class, 'getDeprecatedDescription')) {

Copy link

Member

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're on 0.12 already, this method always exists.

src/Rules/Deprecations/TypeHintDeprecatedInClosureSignatureRule.php Outdated

$errors = [];

foreach ($functionSignature->getParameters() as $i => $parameter) {

/** @var ParameterReflection $parameter */

Copy link

Member

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This @var does not have to be here.

src/Rules/Deprecations/TypeHintDeprecatedInClosureSignatureRule.php Outdated

private function getClassDeprecationDescription(ClassReflection $class): string

{

$description = null;

if (method_exists($class, 'getDeprecatedDescription')) {

Copy link

Member

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getDeprecatedDescription always exists

src/Rules/Deprecations/DeprecationHelper.php Outdated

use PHPStan\Broker\Broker;

use PHPStan\Reflection\ClassReflection;

trait DeprecationHelper

Copy link

Member

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dislike traits. Make this a service that's injected into the constructor instead. Thank you.

ondrejmirtes

ondrejmirtes reviewed

Jul 23, 2019

View reviewed changes

rules.neon

- PHPStan\Rules\Deprecations\InstantiationOfDeprecatedClassRule

- PHPStan\Rules\Deprecations\TypeHintDeprecatedInClassMethodSignatureRule

- PHPStan\Rules\Deprecations\TypeHintDeprecatedInClosureSignatureRule

- PHPStan\Rules\Deprecations\TypeHintDeprecatedInFunctionSignatureRule

Copy link

Member

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeHintDeprecatedInFunctionSignatureRule should be in different commit.

paxal added 4 commits

July 24, 2019 18:52

@paxal


 Rename tests for typehint deprecation check in class method

6bd7a15

@paxal


 Introduce DeprecatedClassHelper

2b58d9a

@paxal


 Add deprecation check for anonymous function typehints

16b0adf

@paxal


 Add deprecation for function typehints

51e7861

@paxal paxal force-pushed the typehint_function_signature branch from ebf68c2 to 51e7861 Compare

July 24, 2019 17:10

@paxal

Copy link

Contributor Author

paxal commented Jul 25, 2019

I updated the branch. I'm sorry ‒ I reorganized things a bit so I had to force-push.
Thanks for your patience BTW :)

@ondrejmirtes

Copy link

Member

ondrejmirtes commented Jul 25, 2019

Perfect, thank you!

@ondrejmirtes ondrejmirtes merged commit e932fb5 into phpstan:master

Jul 25, 2019

@ondrejmirtes

Copy link

Member

ondrejmirtes commented Jul 25, 2019

@paxal If you'd be interested, I can always throw more work at you in PHPStan core :) There are many simple bugs that can be fixed if you're willing to dip your toes in the internals :) Since you already know how writing rules work, it should be easy for you to learn a little bit more...

If you're interested, I can give you more info on each issue.

@paxal

Copy link

Contributor Author

paxal commented Jul 25, 2019

Thank you Ondřej, I bookmarked your link :)

Labels

None yet

2 participants

@paxal @ondrejmirtes

Add deprecations errors for functions typehints #15

Add deprecations errors for functions typehints #15

Uh oh!

Conversation

@paxal paxal commented Jun 26, 2019

Uh oh!

paxal commented Jul 23, 2019

Uh oh!

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

Uh oh!

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

Uh oh!

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

Uh oh!

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

Uh oh!

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

Uh oh!

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

Uh oh!

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

Uh oh!

@ondrejmirtes ondrejmirtes Jul 23, 2019

Choose a reason for hiding this comment

Uh oh!

paxal commented Jul 25, 2019

Uh oh!

ondrejmirtes commented Jul 25, 2019

Uh oh!

ondrejmirtes commented Jul 25, 2019

Uh oh!

paxal commented Jul 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants