-
Notifications
You must be signed in to change notification settings - Fork 8k
Update license years for PHP 8.4 #20388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hmmm I would suggest not to mix topics.
ext/random/engine_mt19937.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you think there is an actual memory leak, please do a separated PR.
It is also better to create a branch from an appropriate origin branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert this line.
Such changes have historically only been made on master, I believe. I don't think this should be backported. Even if, then why 8.4 instead of 8.3?
Update license years for PHP 8.4