Skip to content

Improve performance of intval('+0b...', 2) and intval('0b...', 2) #20357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

ndossche wants to merge 1 commit into php:master

from ndossche:intval-bin-opt

Open

Improve performance of intval('+0b...', 2) and intval('0b...', 2) #20357

Changes from all commits

Commits

Show all changes

Select commit

Improve performance of intval('+0b...', 2) and intval('0b...', 2)

ndossche Nov 2, 2025

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

11 changes: 7 additions & 4 deletions ext/standard/type.c

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -173,14 +173,17 @@ PHP_FUNCTION(intval)
		}

		if (strval[offset] == '0' && (strval[offset + 1] == 'b' \|\| strval[offset + 1] == 'B')) {
	if (strval[0] != '-') {
	/* Either "+0b", or "0b" */
	RETURN_LONG(ZEND_STRTOL(strval + 2 + offset, NULL, 2));
	}

		char *tmpval;
		strlen -= 2; /* Removing "0b" */
		tmpval = emalloc(strlen + 1);

	/* Place the unary symbol at pos 0 if there was one */
	if (offset) {
	tmpval[0] = strval[0];
	}
	/* Place the unary symbol at pos 0 */
	tmpval[0] = '-';

		/* Copy the data from after "0b" to the end of the buffer */
		memcpy(tmpval + offset, strval + offset + 2, strlen - offset);
Expand Down