-
Notifications
You must be signed in to change notification settings - Fork 8k
Verify bundled sources using CI - PCRE2 & SLJIT #20354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this, as this is right from a technical PoV, but deferring the action workflow judgement to @TimWolla / @iluuu1994
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong opinions on this. I think it would be better if these files lived outside of .github and also helped updating the libraries themselves (i.e. downloading some revision, updating the hash somewhere, applying the patches, etc.). But I don't maintain any parts of PHP with external code that is pulled in, so I'll defer to those people whether that's actually necessary.
initial PR of #19802
The new CI asserts all bundled files are up-to-date and the CI code also provides trusted documentation of how the bundled deps were added.
On push/PR the CI is run only if the bundled files were changed.
The CI is based on shell scripts that can be easily modified for upgrade and run localy.