-
Notifications
You must be signed in to change notification settings - Fork 8k
Fix GH-20329: Remove CE cache from non-interned file cache strings #20337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+2
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@arnaud-lb
arnaud-lb
force-pushed
the
gh20329
branch
from
October 30, 2025 12:09
e0dff3d to
e088ecb
Compare
@arnaud-lb
arnaud-lb
changed the title
(削除) Remove CE cache from non-interned file cache strings (削除ここまで)
(追記) Fix GH-20329: Remove CE cache from non-interned file cache strings (追記ここまで)
Oct 30, 2025
dstogov
dstogov
reviewed
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think moving all string flags update into UNSERIALIZE_STR() (including IS_STR_CLASS_NAME_MAP_PTR) would be more clear.
I agree. I've updated accordingly
dstogov
dstogov
approved these changes
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Possible fix for GH-20329.
SERIALIZE_STR(), ensure that we update the right copy of the string.ptris an interior pointer toscript->mem, which is SHM or a temporary serialization of the script.bufis the copy ofscript->memthat will be written to the file cache.IS_STR_CLASS_NAME_MAP_PTRflagNB: I'm wondering if the
if (script->corrupted)branch is useful, as we update flags in the same way inUNSERIALIZE_STR().