-
Notifications
You must be signed in to change notification settings - Fork 6
Switch screen functionality #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #4 +/- ## ============================================ + Coverage 80.92% 81.41% +0.48% - Complexity 80 82 +2 ============================================ Files 7 7 Lines 152 156 +4 ============================================ + Hits 123 127 +4 Misses 29 29
Continue to review full report at Codecov.
|
@mikeymike I definitely prefer the approach in this PR - showPrimaryScreen() and showSecondaryScreen() is another option - your call 😊
There's 2 "screens" that I've called primary and secondary here Switching the screen allows doing things without impact the primary one vim and less use this which is why when you quit you have no evidance of it
7a98c26 to
78b2f18
Compare
hmm yes I like primary/secondary ... updated 😀
There's 2 "screens" that I've called main and alternate here
Switching the screen allows doing things without impact the main one
vim and less use this which is why when you quit you have no evidance of it
I was debating about the api for this,
switchScreenand track internally or have two very specific methods and zero internal tracking. Let me know what you think