-
Notifications
You must be signed in to change notification settings - Fork 108
Allow ESC key to "cancel" editing an input #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will need php-school/terminal#10 in order to work.
It will simply return the initial value (empty string or the placeholder text) when the user presses the ESC key, even if the text was modified.
@AydinHassan
AydinHassan
force-pushed
the
Lynesth-patch-1
branch
from
April 2, 2019 09:59
83b867d to
f8064bd
Compare
Codecov Report
@@ Coverage Diff @@ ## master #174 +/- ## ============================================ - Coverage 97.41% 97.26% -0.15% - Complexity 422 423 +1 ============================================ Files 25 25 Lines 1313 1317 +4 ============================================ + Hits 1279 1281 +2 - Misses 34 36 +2
Continue to review full report at Codecov.
|
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will simply return the initial value (empty string or the placeholder text) when the user presses the ESC key, even if the text was modified.