-
-
Notifications
You must be signed in to change notification settings - Fork 317
GoogleMaps: view and viewstreet mode support #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CurlDispatcher: fix decode issue
There are test failures, but I also receive failures on my local without any changes to master.
Is it ok?
There are test failures, but I also receive failures on my local without any changes to master.
Is it ok?
Saddly, yes. Because this library is tested with real http request, it's common to have failures because the sites are continually changing. But I guess this is the best way to, precisally, detect and adapt the library to these changes.
src/Http/CurlDispatcher.php
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change cause other errors, so it's better to fix this issue inside the Url class.
The path is encoded here: https://github.com/oscarotero/Embed/blob/master/src/Http/Url.php#L314
And for a similar issue, I've created this function: https://github.com/oscarotero/Embed/blob/master/src/Http/Url.php#L664 that restore the escaped double colon. So we can consider to unescape also the @ and , characters. This function is applied only to the filename path, but I think it can be applied to the full path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should be private, and the phpdoc explains what does it do.
Seems working! Hope I undestand your idea correctly )
Thanks 👍
GoogleMaps: view and viewstreet mode support
CurlDispatcher: fix decode issue