-
Couldn't load subscription status.
- Fork 63
Add tr_sess_get_nonce_tpm interface #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+86
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superhepper
Superhepper
requested changes
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
I only had one thing that I wanted you to improve.
It looks good. Squash both the commits into one and sign it.
@Superhepper
Superhepper
requested review from
Firstyear,
ionut-arm and
wiktor-k
October 23, 2025 20:00
Signed-off-by: Muxi Yan <muxi.yan@beyondidentity.com>
wiktor-k
wiktor-k
approved these changes
Oct 25, 2025
Superhepper
Superhepper
approved these changes
Oct 26, 2025
@Superhepper
Superhepper
merged commit Oct 26, 2025
14d1810
into
parallaxsecond:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust interface wrapping
Esys_TRSess_GetNonceTPMhas been missing. This PR adds implementation of this wrapper and export the interface for external use.