-
Notifications
You must be signed in to change notification settings - Fork 402
Support 404labfr/laravel-impersonate #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically speaking, one has the ability to provide a custom user resolver in the configuration so this would be better as its own package which relies on owen-it/laravel-auditing and perhaps extends the base user resolver so it can still be used via similar code.
Also if this package starts supporting this impersonation library, it would probably end up supporting other libraries that change the user and that would require extra time and testing from the maintainers.
cesarreyes3
commented
May 21, 2024
It may take some time until you realize this problem, it would be better to have it
I have my doubts still,
it could help to get the real executor of the action in the case of that package, and if that package does not exist it should not affect the performance and it seems fine to me
calebdw
commented
Oct 17, 2024
I use both packages and my audits table has both user and impersonator columns
Closes #903