Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FIx typo in application tutorial #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andersevenrud merged 3 commits into os-js:master from ajmeese7:patch-1
Jan 22, 2022
Merged

FIx typo in application tutorial #37

andersevenrud merged 3 commits into os-js:master from ajmeese7:patch-1
Jan 22, 2022

Conversation

@ajmeese7
Copy link
Member

@ajmeese7 ajmeese7 commented Jan 20, 2022

Comment was a little messed up, it's better now :)

Love the project so far, great work!

andersevenrud reacted with thumbs up emoji
Comment was a little messed up, it's better now :)
Love the project so far, great work!
Copy link
Member

@andersevenrud andersevenrud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change commit message to FIx typo in application tutorial

@ajmeese7 ajmeese7 changed the title (削除) Fixed typo (削除ここまで) (追記) FIx typo in application tutorial (追記ここまで) Jan 21, 2022
Comment was a little messed up, it's better now :)
Love the project so far, great work!
Copy link
Member Author

Is that what you meant?

@andersevenrud andersevenrud merged commit aa4fdbb into os-js:master Jan 22, 2022
Copy link
Member

andersevenrud commented Jan 22, 2022
edited
Loading

You can use the amend feature in git to change the messages and do a force-push to update a PR.

I corrected this manually and merged the changes (so that it would only contain one single commit).

ajmeese7 reacted with thumbs up emoji ajmeese7 reacted with rocket emoji

@ajmeese7 ajmeese7 deleted the patch-1 branch January 22, 2022 02:33
Copy link
Member Author

Great, thanks for the info! Will try to do better on the other PR you requested this in :)

andersevenrud reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andersevenrud andersevenrud andersevenrud requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /