-
-
Couldn't load subscription status.
- Fork 24
Added Middleware documentation in Misc Tutorials #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a few suggestions.
If you look into this, don't do squash or force push before the review is over 😊
Looking good! You just have to remove the src/v3/tutorial/middleware/.DS_Store file that got into this PR and I will merge this :)
Thank you very much! This will get auto deployed.
Oh sorry 🤦♂️
My suggestion is to add that in gitignore. I always use this to generate gitignore file in my projects.
Ah. Using something like that has never really crossed my mind in the OS.js repos because there isn't much to ignore outside node_modules and dist.
Explicitly providing filenames to git add is the best way to not get this unwanted metadata into commits and is a good practice in general in my opinion. But I suppose on Mac (and maybe even Windows) they pop up all over the place, so it should probably be added to the gitignore(s) 🤔
It adds documentation for these changes.
Related #33