-
Notifications
You must be signed in to change notification settings - Fork 89
Remove JRF elements during discover #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when we "skip" a resource, it would help us debug if we new why it was skipped. Suggest adding a "why" clause to the "skip" message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Oops sorry I just saw Derek's review
Hard to make this clearer in a concise way. We have the domain type name (JRF in this case) available, how about:
<Skipping JRF shared library oracle.bi.jbips#11.1.1@0.1>
This would fit with other possible types:
<Skipping WLS shared library oracle.bi.jbips#11.1.1@0.1>
<Skipping SOA shared library oracle.bi.jbips#11.1.1@0.1>
<Skipping Restricted JRF shared library oracle.bi.jbips#11.1.1@0.1>
Uh oh!
There was an error while loading. Please reload this page.
Blacklists were added and applied for applications, coherence clusters, datasources, file stores, JMS resources, JMS servers, shared libraries, startup and shutdown classes, and WLDF resources. Fixes #199