-
Notifications
You must be signed in to change notification settings - Fork 89
Additional rcudb validation #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this list a constant in case we ever need to use it elsewhere and/or change the items in the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the SSL version value should be a constant since presumably, it may change in the future?
Kudos, SonarCloud Quality Gate passed! Quality Gate passed
Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells
This PR adds more validations to RCUDbinfo:
(1) databaseType must be ATP, SSL or ORACLE
(2) check for file existence for data source params property that reference file: keystore, truststore
(3) log RCU data source driver param setting to assist diagnostics