-
Notifications
You must be signed in to change notification settings - Fork 89
Added changes to support TWO-WAY Authentication while connecting to oracle DB while bringing up JRF domain #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.
When singing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the documentation update on this changes ? You should update
documentation/2.0/content/rcuinfo.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you add a positional parameter at the end of the function with default value (e.g. encrypted = False), then you don't have to duplicate the entire method. Then the caller only have to call with encrypted = True when needed. This avoid having duplicate code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corresponding changes has been done and pushed please verify
Where is the documentation update on this changes ? You should update
documentation/2.0/content/rcuinfo.md
Documentation was already present for all trust/keystore properties...only properties required for TWO_WAY SSL DB communication was not set while creating weblogic domain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are adding functionality, you must update the documentation--either in this or a separate PR. We will consider this PR once we see the documentation changes.
documentation/2.0/content/rcuinfo.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*required - this is spelled "reuired" in 4 places, including old and new examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, thanks for the review
Kudos, SonarCloud Quality Gate passed! Quality Gate passed
Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells
Current implementation was not supporting TWO-WAY SSL while connecting to RCU schema on Oracle SSL DB.
Added changes to set properties to support the same while configuring WebLogic Domain.