-
Notifications
You must be signed in to change notification settings - Fork 89
Wdt 1112 appfileoverrides #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes
core/src/main/python/wlsdeploy/tool/deploy/applications_deployer.py
Outdated
Show resolved
Hide resolved
core/src/main/python/wlsdeploy/tool/discover/deployments_discoverer.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
method name is _create_application_directory
core/src/main/java/oracle/weblogic/deploy/util/WLSDeployArchive.java
Outdated
Show resolved
Hide resolved
core/src/main/java/oracle/weblogic/deploy/util/WLSDeployArchive.java
Outdated
Show resolved
Hide resolved
core/src/main/java/oracle/weblogic/deploy/util/WLSDeployArchive.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this level of intention is consistent with the rest of the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hate to be a pain but please change this name to applicationFolders to more accurately reflect the purpose/content. That is, this is a location for structured application folders not a single folder for applications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you don't like that, we could change to structuredApplications instead...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think structuredApplications is clearer for the user. Sounds more intuitive as to why we separated the two application types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one rename, the rest looks fine. Thanks.
Kudos, SonarCloud Quality Gate passed! Quality Gate passed
Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells
Fixes #1112
Handle application folder directories that contain app and plan directories.
Write directory to plan.xml config-root
make sure directory output is correct for option -remote