-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix numbering #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fix numbering #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@gparlakov
Copy link
@gparlakov
gparlakov
commented
Oct 22, 2018
@gparlakov did you submit the OCA, which is required for contributions to be accepted? If not, I could just treat this as a bug report.
Hi,
Please treat it as a bug report. Very complicated to sign the thing, sorry.
... On Tue, Oct 30, 2018, 16:15 Christopher Jones ***@***.***> wrote:
@gparlakov <https://github.com/gparlakov> did you submit the OCA
<https://github.com/oracle/node-oracledb/blob/master/CONTRIBUTING.md>,
which is required for contributions to be accepted? If not, I could just
treat this as a bug report.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#999 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADUiV8A3dTwcDwWYGvgrFwNlZ0mib8Ywks5uqF74gaJpZM4Xy7Eg>
.
Done. Thanks. It'll come out in the next version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.