feature: Support bigint parameters in thin mode #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

sla100 wants to merge 1 commit into oracle:main from sla100:fetaure-support-bigint-input-bind-value

Closed

feature: Support bigint parameters in thin mode #1572

sla100 wants to merge 1 commit into oracle:main from sla100:fetaure-support-bigint-input-bind-value

Conversation

@sla100

Copy link

@sla100 sla100 commented Jun 9, 2023

Hello. There is a simple change which allow to pass build-in bigint type to parameters in thin node.
This allows you to pass large integers without conversion to string in js and CAST on the Oracle side.
Ex.:

const {rows} = await conn.execute( 'SELECT null FROM DUAL WHERE :A = (CAST :B AS NUMBER)', {
 A: 1_000_000_000_000_001n,
 B: 1_000_000_000_000_001n.toString(),
});
equal(rows.length, 1);

Signed-off-by: Sławomir Osoba <you@example.org>

@sla100


 feature: support bigint

60d8f41

@oracle-contributor-agreement

Copy link

oracle-contributor-agreement bot commented Jun 9, 2023

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

PR author: @sla100
slawomir.osoba@gmail.com

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required label

Jun 9, 2023

@cjbj cjbj added oca-verified and removed OCA Required labels

Jun 13, 2023

@sharadraju

Copy link

Member

sharadraju commented Jun 13, 2023

We would also need to think about how to retrieve data from Oracle Database as bigint datatype as well.

@sla100

Copy link

Author

sla100 commented Jun 13, 2023

We would also need to think about how to retrieve data from Oracle Database as bigint datatype as well.

This translation is already possible for columns.

const fetchTypeHandler = ({dbType, precision, scale}) => {
 if (dbType === oracledb.DB_TYPE_NUMBER && scale === 0 && precision > 15) {
 return {
 type: oracledb.STRING,
 converter: (v) => v === null ? null : BigInt(v),
 };
 }
};

@stale

Copy link

stale bot commented Aug 12, 2023

This issue has been automatically marked as inactive because it has not been updated recently. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label

Aug 12, 2023

@sharadraju sharadraju removed the inactive label

Aug 18, 2023

@stale

Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as inactive because it has not been updated recently. It will be closed if no further activity occurs. Thank you for your contributions.