-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix Booleans at njsDbObject_transformFromOracle #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Support 'PL/SQL BOOLEAN' at tranformation from DBObject to Javascript values. Signed-off-by: Diego Arce <Diego@arce.cr>
Can you point me at your OCA entry?
Can you point me at your OCA entry?
I emailed it in few hours ago.
That's great! I'll ask the OCA team to keep an eye out for it.
1. Support 'PL/SQL BOOLEAN' as OUT parameter to Javascript value. Signed-off-by: Diego Arce <Diego@arce.cr>
1. Support bind 'PL/SQL BOOLEAN' type as IN parameter in PL/SQL store procedures. Signed-off-by: Diego Arce <Diego@arce.cr>
1. Support 'PL/SQL BOOLEAN' at tranformation to DBObject from Javascript values. Signed-off-by: Diego Arce <Diego@arce.cr>
src/njsVariable.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is not needed as booleans cannot be fetched. They can only be used in PL/SQL.
src/njsVariable.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is not needed as booleans cannot be fetched. They can only be used in PL/SQL.
@arcezd thanks for getting the OCA submitted. You can see @anthony-tuininga has some comments; more on this below.
If you're not aware of the process we use, we'll merge your PR to a private git repo (where we work on things like not-yet released Oracle DB features), and then merge back to GitHub, and make a release.
For timing reasons, don't worry about making the trivial changes noted by @anthony-tuininga. He'll make them when we merge the PR. We'll add tests and doc too.
Signed-off-by: Diego Arce <Diego@arce.cr>
@arcezd this finally landed in node-oracledb 4.2. It coincided nicely with the other bind changes. Thanks!
Signed-off-by: Diego Arce Diego@arce.cr
#1189