Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix endsWith() to the correct version endswith() in mx_sdk_vm_impl.py #12373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graalvmbot merged 1 commit into oracle:master from simonis:patch-1
Oct 28, 2025

Conversation

@simonis
Copy link
Contributor

@simonis simonis commented Oct 15, 2025
edited
Loading

Apparently, the PR [GR-70588] Include the GraalVM version rather than the Java version in the vendor version and basedir name (i.e. commit 270badf98ef4bb) introduced a Python typo because it used endsWith() instead of endswith(). This lets my builds fail.

It's strange that thiy typo hasn't been caught by any tests

...l.py
Apparently, the PR [[GR-70588] Include the GraalVM version rather than the Java version in the vendor version and basedir name](oracle#12319) (i.e. [commit 270badf](oracle@270badf) introduced a Python type because it used `endsWith()` instead of `endswith()`. This lets my builds fail.
It's strange that thiy typo hasn't been caught by any tests
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 15, 2025
Copy link
Contributor Author

simonis commented Oct 24, 2025

@gilles-duboscq, @daloze could you please have a quick look at this trivial fix?

Copy link
Member

Looks good, thanks.

Which java version did you use? I suppose that we didn't run into a JDK with a "pre-release" component to its version.

I'll push this in.

@graalvmbot graalvmbot merged commit a2bb390 into oracle:master Oct 28, 2025
13 checks passed
Copy link
Contributor Author

simonis commented Oct 30, 2025

Thanks!

Which java version did you use? I suppose that we didn't run into a JDK with a "pre-release" component to its version.

Yes, I always build my JDK myself, I'm a JVM engineer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /