-
Notifications
You must be signed in to change notification settings - Fork 833
Crash fix - when cancelling an authentication session #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verified the crash described occurs in iOS example app with Okta and that the proposed fix prevents the crash.
@Prash88 Do you mind fixing the failing tests, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to repro
In Example app,
Tap sign in, hit continue.
Move the app to the background.
Go to Settings > Safari > Clear History and Website Data.
Go into the app again. A new permission dialog is shown.
Tap Cancel. App crashes.
Recording from example app: https://streamable.com/5m16cx
Reasons for crash
The crash happens because of ASWebAuthenticationSession getting deallocated during or immediately after completion handler
http://ww.openradar.appspot.com/FB12132525
Fix explanation
As suggested, this crash can be mitigated by intentionally retaining the authentication session until after the dismiss animation is complete.